Skip to content

Correct attribution links formating#715

Merged
thinkingserious merged 1 commit intov4from
unknown repository
Oct 30, 2018
Merged

Correct attribution links formating#715
thinkingserious merged 1 commit intov4from
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Oct 28, 2018

Fixes #671

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • Change attribution links into bullet points to match CoC in other Sendgrid repos.

If you have questions, please send an email to SendGrid, or file a GitHub Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 28, 2018
@ghost
Copy link
Copy Markdown
Author

ghost commented Oct 28, 2018

@misterdorm Rebased to v4 branch from #672

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 28, 2018 •
edited
Loading

Codecov Report

Merging #715 into v4 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##               v4     #715   +/-   ##
=======================================
  Coverage   84.35%   84.35%           
=======================================
  Files          36       36           
  Lines         965      965           
  Branches      107      107           
=======================================
  Hits          814      814           
  Misses         93       93           
  Partials       58       58

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edd02e4...2546fa3. Read the comment docs.

@misterdorm misterdorm added hacktoberfest difficulty: easy fix is easy in difficulty and removed status: code review request requesting a community code review or review from Twilio labels Oct 29, 2018
@thinkingserious
Copy link
Copy Markdown
Contributor

thinkingserious commented Oct 29, 2018

Hello @PyroclasticMayhem,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@misterdorm misterdorm added status: work in progress Twilio or the community is in the process of implementing type: docs update documentation change not affecting the code labels Oct 29, 2018
@thinkingserious thinkingserious merged commit f04267b into sendgrid:v4 Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

difficulty: easy fix is easy in difficulty status: work in progress Twilio or the community is in the process of implementing type: docs update documentation change not affecting the code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@thinkingserious @misterdorm